[PATCH] D100273: [VectorCombine] Scalarize vector load/extract.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 19 06:39:58 PDT 2021
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:888
+ FixedVT->getElementType(), GEP, EI->getName() + ".scalar"));
+ NewLoad->setAlignment(Align(1));
+ replaceValue(*EI, *NewLoad);
----------------
RKSimon wrote:
> Why are you forcing the alignment ?
I think we have to update the alignment of the scalar load, because after applying an offset to the pointer it may not be aligned as specified on the original load. I think we should be able to use the common alignment between the alignment on the load and the scalar type. WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100273/new/
https://reviews.llvm.org/D100273
More information about the llvm-commits
mailing list