[PATCH] D100489: [llvm-readobj] Fix dumping dynamic relative relocations for SHT_REL

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The patch title tags llvm-readobj, but this is an llvm-objdump change.



================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-dynamic-relocs-rel.test:1-3
+## Show that llvm-objdump can dump dynamic relocations for Elf_Rel relocations
+## Previously printing the R_386_RELATIVE relocations would trigger
+## error: can't read an entry at 0x40: it goes past the end of the section (0x40)
----------------
I don't think you need the "Previously ..." sentence at all. What you probably do want to say is that this test shows that Elf_Rel relocations can be dumped for both cases with and without a corresponding symbol, something like the inline edit.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-dynamic-relocs-rel.test:9
+
+# CHECK:      file format elf32-i386
+# CHECK-LABEL: DYNAMIC RELOCATION RECORDS
----------------
I don't think this line is useful?


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-dynamic-relocs-rel.test:11-12
+# CHECK-LABEL: DYNAMIC RELOCATION RECORDS
+# CHECK-NEXT: 00000030 R_386_RELATIVE *ABS*
+# CHECK-NEXT: 00000010 R_386_NONE foo
+# CHECK-EMPTY:
----------------
Nit suggestion to make things line up nicely.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-dynamic-relocs-rel.test:61-63
+Symbols:
+  - Name:    foo
+    Section: .data
----------------
I think you can omit the static symbol?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100489/new/

https://reviews.llvm.org/D100489