[PATCH] D99935: [AArch64] Add instruction costs for FP_TO_UINT and FP_TO_SINT with half types

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Hey @david-arm,
Just a comment, it is me or this table is not well suited to review?
 It lists the types by their cost.  It should have put together instruction/types instead of instruction/cost. 
I see some types/sizes missing like nxv8i32 ->nxv8f32 and nxv4i64 -> nxv4f64, but I guess they are not legal types, or I could miss it, as this table does not help me to find the types.
Is that correct?



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:579
+    // Complex, from nxv2f16.
+    { ISD::FP_TO_SINT, MVT::nxv2i64, MVT::nxv2f16, 1 },
+    { ISD::FP_TO_SINT, MVT::nxv2i32, MVT::nxv2f16, 1 },
----------------
So much better to check if all types are covered when it is like this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99935/new/

https://reviews.llvm.org/D99935