[PATCH] D99718: [LoopVectorize] Simplify scalar cost calculation in getInstructionCost

Mon Apr 19 04:12:26 PDT 2021

fhahn added a comment.

In D99718#2663523 <https://reviews.llvm.org/D99718#2663523>, @david-arm wrote:

> A version of this patch was previously merged (D98512 <https://reviews.llvm.org/D98512>) then reverted due to a failure with the X86 sanitiser build that exposed some missing tests from our LLVM test suite regarding pointer PHIs feeding directly into stores. I've attempted another fix here without the previous assert because the logic seems far too complicated for an assert.

I'm not sure I follow why the logic would be far too complicated for an assert? There are asserts that verify the whole dominator tree or the whole function, which seems much more complicated :) Also, IIUC the assert caught a case that was missing from the comment/explanation in the initial patch, so it seems like it was doing what it was supposed to be?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99718/new/

https://reviews.llvm.org/D99718