[PATCH] D100721: [SCEVExpander] Try to create ASHR instr for expanded SCEV expr.

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 02:52:40 PDT 2021


mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:813
+    auto *Abs = dyn_cast<SCEVSMaxExpr>(Div->getOperand(0));
+    if (!Abs || Abs->getOperand(0) != SE.getNegativeSCEV(Abs->getOperand(1)))
+      return false;
----------------
I think there is a bug here for `Abs->getOperand(0) == Abs->getOperand(1) == SINT_MIN`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100721/new/

https://reviews.llvm.org/D100721



More information about the llvm-commits mailing list