[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

Mon Apr 19 02:21:38 PDT 2021

simoll marked 13 inline comments as done.
simoll added inline comments.

================
Comment at: llvm/test/CodeGen/Generic/expand-vp.ll:1
+; Partial expansion cases (still VP with parameter expansions).
+; RUN: opt --expandvp --expandvp-override-evl-transform=Legal --expandvp-override-mask-transform=Legal -S < %s | FileCheck %s --check-prefix=LEGAL_LEGAL
----------------
rogfer01 wrote:
> Just a suggestion: `llvm/utils/update_test_checks.py` can reduce the cost of maintaining this test (I understand we'll have to extend it when VP FP lands).
How about we switch to an auto-generated test once caching is in and the code has stabilized?
Without caching the output is very verbose.. also auto-generated tests are really sentinels for change not actually //tests//

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203