[PATCH] D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

Just a minor thing: the description has a typo in `PatterntToMatch` with an extra 't'.



================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.h:1080
   const std::vector<Record*> &getDstRegs() const { return Dstregs; }
+  const std::string &getHwModeFeatures() const { return HwModeFeatures; }
   int         getAddedComplexity() const { return AddedComplexity; }
----------------
Just wondering: would `StringRef` be more appropriate here? Maybe it's not idiomatic to tablegen code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100691/new/

https://reviews.llvm.org/D100691