[PATCH] D100632: [DebugInfo] Move the findDbg* functions into DebugInfo.cpp

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Thanks all.



================
Comment at: llvm/include/llvm/IR/DebugInfo.h:37
+/// dbg.addr intrinsics.
+TinyPtrVector<DbgVariableIntrinsic *> FindDbgAddrUses(Value *V);
+
----------------
rnk wrote:
> Not related, but we should remove dbg.addr since it sounds like dbg.value+DW_OP_deref is the preferred representation of the same thing.
Would we need to discuss this on llvm-dev (or create a ticket) before hand?

I know @jmorse has mentioned elsewhere liking the idea of having a separate intrinsic to describe memory locations.

My only experience with dbg.addr is when I tried using them as an alternative to dbg.value+DW_OP_deref while working on [[ https://bugs.llvm.org/show_bug.cgi?id=35318 | PR47946]]. I ran into some problems with them there but I didn't dig too deep.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100632/new/

https://reviews.llvm.org/D100632