[PATCH] D100282: [Coroutines] Set presplit attribute in Clang instead of CoroEarly pass

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 18 17:24:01 PDT 2021


lxfind added a comment.

This broke MLIR tests.
It seems that MLIR tests depend on CoroEarly to be able to annotate coroutine function properly based on the intrinsics.
Given that, I am now convinced we shouldn't set the attribute in the frontend. Instead we should simply move CoroEarly to before AlwaysInliner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100282/new/

https://reviews.llvm.org/D100282



More information about the llvm-commits mailing list