[PATCH] D100353: Support optnone in SCCP

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 18 09:38:31 PDT 2021


dblaikie added a comment.

In D100353#2694589 <https://reviews.llvm.org/D100353#2694589>, @probinson wrote:

> Probably should drop a note to llvm-dev, as the title of this review doesn't suggest it's redefining optnone.

Fair point

In D100353#2694602 <https://reviews.llvm.org/D100353#2694602>, @lebedev.ri wrote:

> I don't like this redefinition.
> I would suggest to introduce `noipa` attribute, like i thought this patch does.

Hrm - wasn't expecting much disagreement here, based on my understanding of optnone. My mistake - posted an llvm-dev thread to further the discussion here: https://lists.llvm.org/pipermail/llvm-dev/2021-April/149960.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100353/new/

https://reviews.llvm.org/D100353



More information about the llvm-commits mailing list