[PATCH] D100717: [InstCombine] Transform memcpy to ptr load/stores if TBAA says so

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 18 03:09:23 PDT 2021


fhahn added a comment.

I don't see how this use of TBAA metadata is within the specification of the metadata.

IIUC the type descriptors only encode the layout and relationship between types, but not whether a scalar type is a pointer, integer, floating point or other type. It just happens to be that Clang uses names that are related to the source types. But IIUC those names are arbitrary and Clang could just as well use `A`, `B`, `C`,... or any other naming scheme.

Please let me know if I am missing something that provides the guarantees the patch uses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100717/new/

https://reviews.llvm.org/D100717



More information about the llvm-commits mailing list