[PATCH] D100716: [WebAssembly] Use v128.const instead of splats for constants

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 18 00:24:33 PDT 2021


tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100.
tlively requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We previously used splats instead of v128.const to materialize vector constants
because V8 did not support v128.const. Now that V8 supports v128.const, we can
use v128.const instead. Although this increases code size, it should also
increase performance (or at least require fewer engine-side optimizations), so
it is an appropriate change to make.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100716

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
  llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
  llvm/test/CodeGen/WebAssembly/implicit-def.ll
  llvm/test/CodeGen/WebAssembly/simd-offset.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100716.338358.patch
Type: text/x-patch
Size: 8843 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210418/2bce345f/attachment.bin>


More information about the llvm-commits mailing list