[PATCH] D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added a comment.

I presume this passes all the TableGen tests.

How else did you test it? Knowing this may help me in the future.



================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:1436
 
+SmallVector<Record *, 4> PatternToMatch::getPredicateRecords() const {
+  SmallVector<Record *, 4> PredicateRecs;
----------------
No need to mention initial size ", 4" in the function definition, is there?


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:1477
+    PredicateCheck += HwModeFeatures;
+    PredicateCheck += "\"))";
   }
----------------
Any reason you didn't combine the catenations with '+' ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100691/new/

https://reviews.llvm.org/D100691