[PATCH] D100122: Update m_Undef to match vectors/aggrs with undefs and poisons mixed

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 17 06:07:44 PDT 2021


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM.
Please split this patch into two - the matcher+unittest, and the usage of the matcher.



================
Comment at: llvm/include/llvm/IR/PatternMatch.h:121-122
+
+    if (CheckValue(CA))
+      return false;
+
----------------
Hm, i'd invert the `CheckValue()`'s return value, this seems unnatural.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100122/new/

https://reviews.llvm.org/D100122



More information about the llvm-commits mailing list