[PATCH] D100122: Update m_Undef to match vectors/aggrs with undefs and poisons mixed
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 17 05:48:00 PDT 2021
lebedev.ri added inline comments.
================
Comment at: llvm/include/llvm/IR/PatternMatch.h:103
+
+ // Returns: is never undef?
+ auto CheckValue = [&](const ConstantAggregate *CA) {
----------------
Sorry for being nitpicky, but is that what it returns?
Wouldn't it have to then return false for e.g. constant expressions, since they could be `undef`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100122/new/
https://reviews.llvm.org/D100122
More information about the llvm-commits
mailing list