[PATCH] D100122: Update m_Undef to match vectors/aggrs with undefs and poisons mixed

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

last few nits



================
Comment at: llvm/include/llvm/IR/PatternMatch.h:111-112
+        if (!CA)
+          return true;
+        else if (Seen.insert(CA).second)
+          Worklist.emplace_back(CA);
----------------
no else after return


================
Comment at: llvm/include/llvm/IR/PatternMatch.h:131-132
+
+/// Match an arbitrary undef constant. This matches poison as well.
+inline auto m_Undef() { return undef_match(); }
 
----------------
I think this should state what happens about partial cases,
i.e. is `{ undef, 0 }` an undef? I guess not, it should not match.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100122/new/

https://reviews.llvm.org/D100122