[PATCH] D100331: [Dependence Analysis] Fix ExactSIV producing wrong analysis

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 16 16:12:22 PDT 2021


Meinersbur added a comment.

This change reverses almost all directions in the test cases. Was the implementation that terribly wrong?

Not having studies the used algorithms myself, I assumed the DA result to be correct and when using it as analysis assumed that `flow [<]` and `anti [>]` are anti-dependences (WAR).



================
Comment at: llvm/lib/Analysis/DependenceAnalysis.cpp:1967-1969
+  if (TLVec.empty() || TUVec.empty()) {
+    return false;
+  }
----------------
[style] [[ https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements | Don’t Use Braces on Simple Single-Statement Bodies of if/else/loop Statements ]]


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100331/new/

https://reviews.llvm.org/D100331



More information about the llvm-commits mailing list