[PATCH] D94202: Preserve the lexical order for global variables during llvm-link merge

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

OK, much nicer already (IMHO).

I think the only thing left to do is to document the "sort" function properly. It's arguably not a trivial sort, see below.



================
Comment at: llvm/include/llvm/ADT/simple_ilist.h:270
+  void sort(simple_ilist &RHS, DenseMap<pointer, pointer> &DM, iterator First,
+            iterator Last, Compare comp);
   ///@}
----------------
This function, at least the comment, is not generic (this is ilist after all) and not really explaining what is going on. I don't mind this function here but maybe make the name, and the comment, more descriptive. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94202/new/

https://reviews.llvm.org/D94202