[PATCH] D100669: [ADT] Add std::remove_cvref and std::remove_cvref_t

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 16 13:54:35 PDT 2021


dblaikie added a comment.

Change the title (this patch isn't adding any std:: things, it's adding llvm:: things that are equivalent to std:: things) and I think drop the "SHIM" macro (but we'll take that up in the precursor patch that introduces that macro)

Testing - I'm not a huge fan of stamping out tests with macros - makes the tests in some ways harder to read/understand what they're testing. Not sure it's better, but gtest does offer a type based test expansion - maybe you could use that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100669/new/

https://reviews.llvm.org/D100669



More information about the llvm-commits mailing list