[PATCH] D100640: [SimplifyCFG] Skip dbg intrinsics when checking for branch-only BBs.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1442
       return false;
-    if (!I1->isTerminator())
+    if (!I2NonDbg->isTerminator())
       return false;
----------------
fhahn wrote:
> uabelho wrote:
> > Since I1NonDbg and I2NonDbg should be identical here I guess it doesn't really matter, but anyway: Wouldn't it make the patch look a little bit simpler if we used I1NonDbg here rather than changing from I1 to I2NonDbg?
> That's indeed better, thanks. Updated!
I think this isn't quite right. Sure, they are free to host. But now we will simply always drop them?
I think we should still hoist all identical debug info, and skip the rest of the debuginfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100640/new/

https://reviews.llvm.org/D100640