[PATCH] D100358: GlobalISel: Defer register creation in handleAssignments

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:558-574
-      // We need to extract the individual parts.
-      assert(Args[i].OrigRegs.empty());
-      Args[i].OrigRegs.push_back(Args[i].Regs[0]);
-
-      ISD::ArgFlagsTy OrigFlags = Args[i].Flags[0];
-      // We're going to replace the regs and flags with the split ones.
-      Args[i].Regs.clear();
----------------
aemerson wrote:
> Where's this logic going?
These two blocks were 90% identical. Now the flag splitting and assignment is only done up here, and the register creation moved below


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100358/new/

https://reviews.llvm.org/D100358