[PATCH] D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition

[Eric Astor via Phabricator via llvm-commits]

epastor added a comment.

In D92505#2694696 <https://reviews.llvm.org/D92505#2694696>, @thakis wrote:

> (this didn't have me as a reviewer, so I only saw it by coincidence)
>
> We should also add the `/WX` switch :)

That was added in https://reviews.llvm.org/D92504.

> If I read it right, this isn't ready to go yet, right?

Correct; I need to investigate more corner cases in ML.EXE. It's unclear how ML.EXE handles redefinitions... when I read the spec as suggesting that (e.g.) test5 should be replaced by def before the line is even parsed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92505/new/

https://reviews.llvm.org/D92505