[PATCH] D100169: [ADT] Update RPOT to work with specializations of different types.

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

Looks like a nice clean up; LGTM.

> The patch also updates a couple of functions that unnecessarily took the
> input graph by value, when it was not needed. They can take the graph by
> const-reference instead, which does not require GraphT to provide a copy
> constructor. This technically is a separate change, but is required to
> be able to use Graph<> from TestGraph in the test, because it does not
> provide a copy constructor. If desired, I can split this out as a
> separate change.

My tendency would usually be an NFC prep commit as you suggest, but at the same time it's nice to land a coincident, motivating use case (which would be the Graph test). Either way seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100169/new/

https://reviews.llvm.org/D100169