[PATCH] D100557: [GC][NFC] Move GCStrategy from CodeGen to IR

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Max, thank for you doing this.  I think this is a really good idea.

I had tried this once before and ran into trouble with the build bots.  Have you built this with both static and dynamic build modes?  I forget which one bit me last time, but we had to revert for some reason.  You can probably find the reverting commit by looking at history.

I vaguely remember the problem being something about the registery mechanism and circular build dependencies, but its been a very long time since I've thought about this.

If you can confirm that problem no longer exists, this will be an easy LGTM.



================
Comment at: llvm/include/llvm/CodeGen/LinkAllCodegenComponents.h:17
 
-#include "llvm/CodeGen/BuiltinGCs.h"
+#include "llvm/IR/BuiltinGCs.h"
 #include "llvm/CodeGen/Passes.h"
----------------
Remember to sort the headers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100557/new/

https://reviews.llvm.org/D100557