[PATCH] D100476: [AArch64][SVEIntrinsicOpts] Replace last{a,b} intrinsic calls with extracts...

[Joe Ellis via Phabricator via llvm-commits]

joechrisellis marked an inline comment as done.
joechrisellis added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:292-296
+    Value *Pg = II.getArgOperand(0);
+    Value *Vec = II.getArgOperand(1);
+    bool IsAfter = IID == Intrinsic::aarch64_sve_lasta;
+
+    auto *C = dyn_cast<Constant>(Pg);
----------------
paulwalker-arm wrote:
> Can the actual combine live in its own function? (for example into instCombineSVELast ) Otherwise this function is going to become unreadable?
Sure! The only reason that I didn't do this the first time is because it didn't look like there was much precedent for breaking down the TTI::instCombineIntrinsic into specific combine functions for other targets. Happy to change if we want to do things differently though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100476/new/

https://reviews.llvm.org/D100476