[PATCH] D100657: [Support] Don't include <algorithm> in Hashing.h
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 16 09:29:57 PDT 2021
thakis added a comment.
In D100657#2695067 <https://reviews.llvm.org/D100657#2695067>, @NathanielMcVicar wrote:
> This broke the Windows MLIR buildbot, because algorithm is required for std::min in MSVC.
> https://lab.llvm.org/buildbot/#/builders/13/builds/6985/steps/6/logs/stdio
(For this one, the Right Fix would be to add the include in APInt.h , or arguably undo parts of http://reviews.llvm.org/rG405165210b0b2f95e08d84ffcaab534fbd022fde , but since Hashing.h does use std::rotate() it needs to keep the include.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100657/new/
https://reviews.llvm.org/D100657
More information about the llvm-commits
mailing list