[PATCH] D91516: [AMDGPU] Replace uses of LDS globals within non-kernel functions by pointers.

[Mahesha S via Phabricator via llvm-commits]

hsmhsm added a comment.

In D91516#2682974 <https://reviews.llvm.org/D91516#2682974>, @JonChesterfield wrote:

> The algorithm I had in mind was along the lines of:
>
>   for each LDS variable:
>     if should-transform
>       create 16 bit integer in LDS
>       initialize that global with (constexpr) address of variable
>       replace all uses of variable with a (constexpr) access through new pointer
>   
>   where
>   should-transform:
>    if (sizeof) < 8ish return false
>    if used by instruction in indirectly called function return false
>    if only used by kernels return false
>    probably other exclusions
>    return true
>    

I think, we all of us, who are involved in discussing about the functionalities related to this patch are not on the same page. First, we need to internally discuss it and make sure that we are all on the same page, before I start making any further changes to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91516/new/

https://reviews.llvm.org/D91516