[PATCH] D100594: [AMDGPU] Strengthen the logic behind collection of LDS globals for lowering.

Fri Apr 16 06:38:33 PDT 2021

hsmhsm added a comment.

In D100594#2694280 <https://reviews.llvm.org/D100594#2694280>, @JonChesterfield wrote:

> Some comments inline.
>
> If this corrects behaviour as described in the comment, it needs tests. I can't see a behaviour change in the diff.
>
> If it's a non functional refactor, I think it makes the code substantially less legible than it was before. Especially dislike using multiple booleans for control flow.

I am confused myself now. I am not able to recollect what was forced me to change the code here. When, I was working on the changes for D91516 <https://reviews.llvm.org/D91516>, there was some test it forced my to re-arrange the code as I did here. Anyhow, let's hold this patch for now, and come back to it, when D91516 <https://reviews.llvm.org/D91516> necessitates it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100594/new/

https://reviews.llvm.org/D100594