[PATCH] D100385: [NFC] Add tests for scalable vectorization of loops with in-order reductions

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 16 06:36:34 PDT 2021


kmclaughlin added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-strict-fadd.ll:206
+; CHECK: middle.block
+; CHECK: %[[RDX:.*]] = call float @llvm.vector.reduce.fadd.nxv8f32(float -0.000000e+00, <vscale x 8 x float> %[[VEC_FADD2]])
+; CHECK: for.body
----------------
david-arm wrote:
> Ok, it looks like this test is actually falling back on a non-strict implementation that reorders FP operations. This happens in this case because we are using hints and allowsReordering always return true for hints.
I think I could remove the hints and instead use `-force-vector-width/interleave` and we would not fall back on the non-strict implementation, if that would be better?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100385/new/

https://reviews.llvm.org/D100385



More information about the llvm-commits mailing list