[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

Fri Apr 16 06:14:04 PDT 2021

abhina.sreeskantharajan added a comment.

In D100488#2692772 <https://reviews.llvm.org/D100488#2692772>, @rnk wrote:

> In D100488#2689494 <https://reviews.llvm.org/D100488#2689494>, @amccarth wrote:
>
>> Personally, I'm not a fan of boolean function parameters because of the inline comments necessary to make the call site understandable.  But it appears to be consistent with LLVM Coding Standards and other APIs, so this looks right to me.
>
> I think it would be a reasonable follow-up change to turn these optional boolean parameters into a flags enum.

That's a good idea. There hasn't been a usage of getFile or getFileOrSTDIN that wanted CRLF translation so far, but this may not be the case always.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100488/new/

https://reviews.llvm.org/D100488