[PATCH] D100485: [AArch64][SVE] Fix crash with icmp+select

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 16 06:02:36 PDT 2021


CarolineConcatto added a comment.

Thank you @sdesmalen  and @c-rhodes for the review.
I'll comment you reviews in here, because the file select-sve.ll is deleted and the tests moved to sve-select.ll
@sdesmalen I have removed the tests you have asked. 
I also remove the Expand in the Lowering for these types:
{MVT::nxv8i8, MVT::nxv4i16, MVT::nxv2i32}
as I believe this happens by default. 
@c-rhodes the tests from select-sve.ll are now in sve-select.ll and select-sve.ll deleted. 
That is already on main.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100485/new/

https://reviews.llvm.org/D100485



More information about the llvm-commits mailing list