[PATCH] D100463: [AArch64][SVEIntrinsicOpts] Fold sve_convert_from_svbool(zero) to zero

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Nice one, thanks. This Looks good to me.



================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:3003
+    return ConstantInt::getFalse(SVTy);
+  } break;
+  default:
----------------
Doesn't need a break after the return (unless it's quieting a warning, but I think most compilers treat this sensibly).


================
Comment at: llvm/test/Transforms/InstSimplify/ConstProp/AArch64/aarch64-sve-convert-from-svbool.ll:1
+; RUN: opt -instsimplify -S -o - < %s | FileCheck %s
+
----------------
If this folder is new it may need (or at least be best) to have a lit.local.cfg to only run it when AArch64 is a registered target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100463/new/

https://reviews.llvm.org/D100463