[PATCH] D100640: [SimplifyCFG] Skip dbg intrinsics when checking for branch-only BBs.

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 16 04:40:59 PDT 2021


uabelho added a comment.

I've verified that this fixes the problem I saw. Thanks!



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1442
       return false;
-    if (!I1->isTerminator())
+    if (!I2NonDbg->isTerminator())
       return false;
----------------
Since I1NonDbg and I2NonDbg should be identical here I guess it doesn't really matter, but anyway: Wouldn't it make the patch look a little bit simpler if we used I1NonDbg here rather than changing from I1 to I2NonDbg?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100640/new/

https://reviews.llvm.org/D100640



More information about the llvm-commits mailing list