[PATCH] D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/Transforms/MemCpyOpt/memset-merged-loc.ll:41
+; Function Attrs: argmemonly nofree nosync nounwind willreturn writeonly
+declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1 immarg) #0
+
----------------
Since we deleted the attributes, we don't need the `#0` anymore.


================
Comment at: llvm/test/Transforms/MemCpyOpt/memset-merged-loc.ll:2
+; RUN: opt -memcpyopt -S < %s | FileCheck %s
+; CHECK: !{{[0-9]+}} = !DILocation(line: 0, scope: !{{[0-9]+}})
+
----------------
jmorse wrote:
> The test should check that the memset call has this metadata attached to it.
(Super nit)
Instead of `; COM:` for comments in tests, we use `;;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100270/new/

https://reviews.llvm.org/D100270