[PATCH] D100412: [Aarch64] handle "o" inline asm memory constraints

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/arm64-inline-asm.ll:301
+
+; PR49956
+define void @test_o_output_constraint() {
----------------
The comment may not be needed. This is a simple lack of handling of a particular constraint type. Having the coverage is sufficient. Readers may not want to read the link.


================
Comment at: llvm/test/CodeGen/AArch64/arm64-inline-asm.ll:303
+define void @test_o_output_constraint() {
+; CHECK-LABEL: test_o_output_constraint
+; CHECK: sub sp, sp, #16
----------------
Appending `:` can make the label more unique.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100412/new/

https://reviews.llvm.org/D100412