[PATCH] D99105: [lld-macho] LTO: Unset VisibleToRegularObj where possible

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 15 16:03:33 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/Symbols.h:98
+  // True if this symbol was referenced by a regular (non-bitcode) object.
+  bool isUsedInRegularObj : 1;
 };
----------------
gkm wrote:
> Why the bitfield width here? Do we anticipate adding more flags?
LLD-ELF does have a bunch more flags, I haven't totally vetted them yet to determine if we'll need them. I guess we can skip the bitfield width for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99105/new/

https://reviews.llvm.org/D99105



More information about the llvm-commits mailing list