[PATCH] D100265: [Polly][NFC] Partial refactoring of IslAst and IslAstInfo to use isl++

[Riccardo Mori via Phabricator via llvm-commits]

patacca added a comment.

>> Change the order of attributes in class `IslAst` to reflect the data dependencies so that the destructor won't complain
>
> Nice observation. Did it crash before changing the order?

Yes, it failed some tests. If I remember correctly it was ending up inside `isl_ctx_free()` with a reference counter > 0 and thus calling `isl_die()`.

> The LLVM coding standard uses auto only in very specific cases. In the past we made liberal use of auto, but when changing a declaration we can use the occasion to bring it to the latest coding standard.No need to update this patch because of this since it is unrelated with what the patch is doing, but something to consider for future patches.

I didn't think too much about it, I will keep it in mind in the future.

Please, go ahead and push it to main.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100265/new/

https://reviews.llvm.org/D100265