[PATCH] D100365: [AArch64] Fix windows vararg functions with floats in the fixed args

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 15 13:01:21 PDT 2021


rnk added a comment.

In D100365#2692146 <https://reviews.llvm.org/D100365#2692146>, @mstorsjo wrote:

> In D100365#2690807 <https://reviews.llvm.org/D100365#2690807>, @maxim-kuvyrkov wrote:
>
>> Please consider backporting this and your other WoA fixes to release/12.x branch.  They may or may not hit the upcoming LLVM 12.0.0 release, but, at least, they'll get into the subsequent update release.
>
> @rnk - What do you think of backporting this kind of fix to 12.0.1 - is it too "big" a change (as it changes the ABI we produce, even if it was wrong before) for that part of the release process?

I'd say go ahead and backport it. I think there are probably more MSVC/Clang WoA ABI boundaries than Clang <12.0.0/Clang 12.0.1 WoA ABI boundaries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100365/new/

https://reviews.llvm.org/D100365



More information about the llvm-commits mailing list