[PATCH] D100573: [ValueTracking] don't recursively compute known bits using multiple llvm.assumes

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 15 11:48:49 PDT 2021


spatel added a comment.

In D100573#2692336 <https://reviews.llvm.org/D100573#2692336>, @nikic wrote:

> That does also suggest a possible alternative approach here, which is to do the same thing we do for phi nodes and do the recursive queries with MaxDepth-1.

Right - I drafted something with that approach, so I can clean it up and post it if that's preferable.

That's a more limiting approach IIUC because that would cut off all recursive analysis for the computeKnownBits calls within computeKnownBitsFromAssume(). The proposal here still allows recursion through other methods like computeKnownBitsFromOperator(), but only clips before we descend via another round of computeKnownBitsFromAssume().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100573/new/

https://reviews.llvm.org/D100573



More information about the llvm-commits mailing list