[PATCH] D100526: [AMDGPU] Move LDS lowering related utility functions to a separate utils file.

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 15 11:26:51 PDT 2021


JonChesterfield added a comment.

Thanks for the refactor. One last request is to move these functions under namespace AMDGPU, as that ensures the symbols can't collide with anyone else. Aside from that, LG.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100526/new/

https://reviews.llvm.org/D100526



More information about the llvm-commits mailing list