[PATCH] D100470: [LICM][NFC] Fix typo
Marcythm via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 15 09:32:54 PDT 2021
Marcythm marked 2 inline comments as done.
Marcythm added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1352
if (auto *LI = dyn_cast<LoadInst>(MD->getMemoryInst())) {
- (void)LI; // Silence warning.
assert(!LI->isUnordered() && "Expected unordered load");
----------------
nikic wrote:
> Marcythm wrote:
> > asbirlea wrote:
> > > Why is this removed?
> > I think that the variable `LI` is used in the following assertion so there won't be an unused-variable warning.
> asserts are not present in NDEBUG builds, which is why this void cast exists.
sorry I'm not aware of this, and it's fixed now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100470/new/
https://reviews.llvm.org/D100470
More information about the llvm-commits
mailing list