[PATCH] D100524: [scudo][standalone] Fuchsia related fixes
Kostya Kortchinsky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 15 08:59:46 PDT 2021
cryptoad added inline comments.
================
Comment at: compiler-rt/lib/scudo/standalone/release.h:83-95
Buffer = reinterpret_cast<uptr *>(
- map(nullptr, BufferSize, "scudo:counters", MAP_ALLOWNOMEM));
+ map(nullptr, roundUpTo(BufferSize, getPageSizeCached()),
+ "scudo:counters", MAP_ALLOWNOMEM));
}
}
~PackedCounterArray() {
if (!isAllocated())
----------------
vitalybuka wrote:
> maybe
`getBufferSize()` is used in the tests and has to correlate to the size of the packed counters array, not the actual mapping size which can be larger.
If changing `BufferSize` here, the tests fail.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100524/new/
https://reviews.llvm.org/D100524
More information about the llvm-commits
mailing list