[PATCH] D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

Apart from maybe needing to run clang-format on the patch, the code changes look good to me.
Before this could be committed, this needs tests.



================
Comment at: llvm/include/llvm/CodeGen/IndirectThunks.h:43-44
 template <typename Derived>
 void ThunkInserter<Derived>::createThunkFunction(MachineModuleInfo &MMI,
-                                                 StringRef Name) {
+                                                 StringRef Name, bool Comdat) {
   assert(Name.startswith(getDerived().getThunkPrefix()) &&
----------------
I'm not entirely sure, but is this how clang-format formats these lines?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100546/new/

https://reviews.llvm.org/D100546