[PATCH] D100486: [COST]Improve cost model for shuffles in SLP.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 15 03:41:11 PDT 2021


fhahn added a comment.

Can you split off the target specific cost model changes? This makes it easier to track down potential regressions.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1408
       { TTI::SK_Reverse, MVT::nxv2i1,   1 },
+      { TTI::SK_Reverse, MVT::v2i32, 1 }, // mov.
+      { TTI::SK_Reverse, MVT::v4i32, 3 }, // perfectshuffle worst case.
----------------
This should be moved up I think, before the scalable vector handling. It would also be good to have cost-model tests for those shuffles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100486/new/

https://reviews.llvm.org/D100486



More information about the llvm-commits mailing list