[PATCH] D100490: [ELF] Check the Elf_Rel addends for dynamic relocations

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 15 03:34:42 PDT 2021


arichardson added inline comments.


================
Comment at: lld/test/ELF/got32-i386-pie-rw.s:3
 # RUN: llvm-mc -filetype=obj -triple=i686-pc-linux %s -o %t.o
+# RUN: llvm-objdump -r -d %t.o | FileCheck %s --check-prefix=OBJ
 # RUN: ld.lld %t.o -o %t -pie
----------------
MaskRay wrote:
> For non-disassembly ELF dumping, prefer llvm-readelf/llvm-readobj. llvm-objdump output tends to have BFD specific stuff. In binutils, readelf does not link against BFD and is immune to the BFD internals.
Sure, I can change this to only dump the relocations, the disassembly is not important for the .o file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100490/new/

https://reviews.llvm.org/D100490



More information about the llvm-commits mailing list