[PATCH] D99723: [ARM] Transforming memcpy to Tail predicated Loop

[Malhar via Phabricator via llvm-commits]

malharJ added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMSelectionDAGInfo.cpp:149
+      return true;
+    if (EnableMemcpyTPLoop == cl::BOU_UNSET)
+      if (!ConstantSize && Alignment >= Align(4))
----------------
dmgreen wrote:
>   if (EnableMemcpyTPLoop == cl::BOU_FALSE)
>     return false;
> 
> Is probably better, if it works as I expect. That keeps the indenting down, and the last if currently isn't in the block it looks like it should be.
> 
> Oh, and move EnableMemcpyTPLoop above the OptSIze/OptNone, in case we want to try and force it. (Even if OptNone doesn't work, using that combo is unlikely to be useful at any rate.)
Ok, my bad there with the braces. 

I've moved the cases when the cli option is **set** to be of higher priority than the optNone/optSize cases ...
but the **unset** case is of Lower priority than (the optNone/optSize) since the user is no longer passing the cli option. 
Hopefully that sounds sensible.


================
Comment at: llvm/lib/Target/ARM/ARMSelectionDAGInfo.cpp:154
+          && ConstantSize->getZExtValue() < Subtarget.getMaxTPLoopInlineSizeThreshold())
+        return true;
+  };
----------------
dmgreen wrote:
> Add a return false at the end?
yep, had missed that out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99723/new/

https://reviews.llvm.org/D99723