[PATCH] D78203: [VP,Integer,#2] ExpandVectorPredication pass

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:71
+
+#undef INTERNAL_VPLEGAL_CASES
+
----------------
I think this should be `VPINTERNAL_VPLEGAL_CASES`


================
Comment at: llvm/test/CodeGen/Generic/expand-vp.ll:1
+; Partial expansion cases (still VP with parameter expansions).
+; RUN: opt --expandvp --expandvp-override-evl-transform=Legal --expandvp-override-mask-transform=Legal -S < %s | FileCheck %s --check-prefix=LEGAL_LEGAL
----------------
Just a suggestion: `llvm/utils/update_test_checks.py` can reduce the cost of maintaining this test (I understand we'll have to extend it when VP FP lands).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78203/new/

https://reviews.llvm.org/D78203