[PATCH] D100288: [RISCV] Add vector types to GPR for P extension and explict type to codegen patterns

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 19:39:16 PDT 2021


jrtc27 added a comment.

In D100288#2690368 <https://reviews.llvm.org/D100288#2690368>, @craig.topper wrote:

> In D100288#2690367 <https://reviews.llvm.org/D100288#2690367>, @jrtc27 wrote:
>
>> In D100288#2690366 <https://reviews.llvm.org/D100288#2690366>, @jrtc27 wrote:
>>
>>> In D100288#2690340 <https://reviews.llvm.org/D100288#2690340>, @Jim wrote:
>>>
>>>> Any comments?
>>>
>>> I think it's worth having the whole stack ready before committing this in case later patches motivate changes to this one.
>>
>> Or at least the MC layer for P
>
> Can we commit the parts of this that aren't really P specific changes so they don't bit rot. Especially the changes to the V extension files.

I guess, though they don't make a huge deal of sense without P even if they're notionally not P-specific, and those could still bit-rot in the tree until P lands


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100288/new/

https://reviews.llvm.org/D100288



More information about the llvm-commits mailing list