[PATCH] D100250: [yaml2obj/obj2yaml/llvm-readobj] Support printing and parsing AVR-specific e_flags

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/avr-elf-headers.test:1
+# RUN: yaml2obj %s -o %t -DFLAG_NAME=EF_AVR_ARCH_AVR1
+# RUN: llvm-readobj -h %t | FileCheck %s -DFLAG_NAME=EF_AVR_ARCH_AVR1 -DFLAG_VALUE=0x1
----------------
Too many invocations can slow down testsuite execution.

When there is a long list of values, we usually just test one invocation or test on invocation with one group of flags.
See D98818. See section-arch-flags.test for another example.
You may consider grouping at least `EF_AVR_ARCH_AVR*` together.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100250/new/

https://reviews.llvm.org/D100250