[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

Yusra Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 14:49:47 PDT 2021


yusra.syeda marked 4 inline comments as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFF.h:73
+  void setContinuation(bool Continuation) {
+    uint8_t Value = Continuation ? 1 : 0;
+    setBits(1, 6, 1, Value);
----------------
anirudhp wrote:
> Couldn't we do away the conditional assignment to `Value` and just pass `Continuation` directly to `setBits`?
Yes, I updated this here and below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437



More information about the llvm-commits mailing list